Check gcloud context_aware/use_client_certificate for mTLS#2
Check gcloud context_aware/use_client_certificate for mTLS#2google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This change adds a fallback check for client certificate usage by querying `gcloud config get context_aware/use_client_certificate`. If the environment variables `GOOGLE_API_USE_CLIENT_CERTIFICATE` and `GOOGLE_API_CERTIFICATE_CONFIG` are not set, the library will now check the gcloud configuration. * Added `get_context_aware_use_client_certificate` to `google/auth/_cloud_sdk.py`. * Updated `check_use_client_cert` in `google/auth/transport/_mtls_helper.py` to use the new check. * Added and updated tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implemented an additional check for mTLS client certificate usage.
Modified
google/auth/_cloud_sdk.py:get_context_aware_use_client_certificate()to querygcloud config get context_aware/use_client_certificate.Modified
google/auth/transport/_mtls_helper.py:check_use_client_cert()to call the new_cloud_sdkhelper if other checks (environment variables) do not result inTrue.Added/Updated Tests:
tests/test__cloud_sdk.py: Added tests forget_context_aware_use_client_certificate.tests/transport/test__mtls_helper.py: Updated tests to cover the new fallback logic and mock the gcloud check.PR created automatically by Jules for task 16361868464918155708 started by @amtk3